Commit d3f2b604 authored by Linus Walleij's avatar Linus Walleij Committed by Jakub Kicinski
Browse files

net: dsa: ks8995: Delete sysfs register access 



There is some sysfs file to read and write registers randomly
in the ks8995 driver.

The contemporary way to achieve the same thing is to implement
regmap abstractions, if needed. Delete this and implement
regmap later if we want to be able to inspect individual registers.

Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
Link: https://patch.msgid.link/20250813-ks8995-to-dsa-v1-3-75c359ede3a5@linaro.org


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent ccf29cb8

drivers/net/dsa/ks8995.c

+0 −47
Original line number Diff line number Diff line
@@ -288,30 +288,6 @@ static int ks8995_reset(struct ks8995_switch *ks) 
	return ks8995_start(ks);

}



static ssize_t ks8995_registers_read(struct file *filp, struct kobject *kobj,

	const struct bin_attribute *bin_attr, char *buf, loff_t off, size_t count)

{

	struct device *dev;

	struct ks8995_switch *ks8995;



	dev = kobj_to_dev(kobj);

	ks8995 = dev_get_drvdata(dev);



	return ks8995_read(ks8995, buf, off, count);

}



static ssize_t ks8995_registers_write(struct file *filp, struct kobject *kobj,

	const struct bin_attribute *bin_attr, char *buf, loff_t off, size_t count)

{

	struct device *dev;

	struct ks8995_switch *ks8995;



	dev = kobj_to_dev(kobj);

	ks8995 = dev_get_drvdata(dev);



	return ks8995_write(ks8995, buf, off, count);

}



/* ks8995_get_revision - get chip revision

 * @ks: pointer to switch instance

 *
@@ -395,16 +371,6 @@ static int ks8995_get_revision(struct ks8995_switch *ks) 
	return err;

}



static const struct bin_attribute ks8995_registers_attr = {

	.attr = {

		.name   = "registers",

		.mode   = 0600,

	},

	.size   = KS8995_REGS_SIZE,

	.read   = ks8995_registers_read,

	.write  = ks8995_registers_write,

};



/* ------------------------------------------------------------------------ */

static int ks8995_probe(struct spi_device *spi)

{
@@ -462,21 +428,10 @@ static int ks8995_probe(struct spi_device *spi) 
	if (err)

		return err;



	memcpy(&ks->regs_attr, &ks8995_registers_attr, sizeof(ks->regs_attr));

	ks->regs_attr.size = ks->chip->regs_size;



	err = ks8995_reset(ks);

	if (err)

		return err;



	sysfs_attr_init(&ks->regs_attr.attr);

	err = sysfs_create_bin_file(&spi->dev.kobj, &ks->regs_attr);

	if (err) {

		dev_err(&spi->dev, "unable to create sysfs file, err=%d\n",

				    err);

		return err;

	}



	dev_info(&spi->dev, "%s device found, Chip ID:%x, Revision:%x\n",

		 ks->chip->name, ks->chip->chip_id, ks->revision_id);
@@ -487,8 +442,6 @@ static void ks8995_remove(struct spi_device *spi) 
{

	struct ks8995_switch *ks = spi_get_drvdata(spi);



	sysfs_remove_bin_file(&spi->dev.kobj, &ks->regs_attr);



	/* assert reset */

	gpiod_set_value_cansleep(ks->reset_gpio, 1);

}