Commit d4026a44 authored by Li Ming's avatar Li Ming Committed by Dave Jiang
Browse files

cxl/hdm: Fix potential infinite loop in __cxl_dpa_reserve() 



In __cxl_dpa_reserve(), it will check if the new resource range is
included in one of paritions of the cxl memory device.
cxlds->nr_paritions is used to represent how many partitions information
the cxl memory device has. In the loop, if driver cannot find a
partition including the new resource range, it will be an infinite loop.

[ dj: Removed incorrect fixes tag ]

Fixes: 991d98f1 ("cxl: Make cxl_dpa_alloc() DPA partition number agnostic")
Signed-off-by: default avatarLi Ming <ming.li@zohomail.com>
Reviewed-by: default avatarIra Weiny <ira.weiny@intel.com>
Reviewed-by: default avatarDave Jiang <dave.jiang@intel.com>
Link: https://patch.msgid.link/20260112120526.530232-1-ming.li@zohomail.com


Signed-off-by: default avatarDave Jiang <dave.jiang@intel.com>
parent 49d10634

drivers/cxl/core/hdm.c

+1 −1
Original line number Diff line number Diff line
@@ -403,7 +403,7 @@ static int __cxl_dpa_reserve(struct cxl_endpoint_decoder *cxled, 
	 * is not set.

	 */

	if (cxled->part < 0)

		for (int i = 0; cxlds->nr_partitions; i++)

		for (int i = 0; i < cxlds->nr_partitions; i++)

			if (resource_contains(&cxlds->part[i].res, res)) {

				cxled->part = i;

				break;