Commit d42d5715 authored by Haoxiang Li's avatar Haoxiang Li Committed by Borislav Petkov (AMD)
Browse files

EDAC/i3200: Fix a resource leak in i3200_probe1() 



If edac_mc_alloc() fails, also unmap the window.

  [ bp: Use separate labels, turning it into the classic unwind pattern. ]

Fixes: dd8ef1db ("edac: i3200 memory controller driver")
Signed-off-by: default avatarHaoxiang Li <lihaoxiang@isrc.iscas.ac.cn>
Signed-off-by: default avatarBorislav Petkov (AMD) <bp@alien8.de>
Cc: stable@vger.kernel.org
Link: https://patch.msgid.link/20251223123202.1492038-1-lihaoxiang@isrc.iscas.ac.cn
parent f8f9c1f4

drivers/edac/i3200_edac.c

+6 −5
Original line number Diff line number Diff line
@@ -358,10 +358,11 @@ static int i3200_probe1(struct pci_dev *pdev, int dev_idx) 
	layers[1].type = EDAC_MC_LAYER_CHANNEL;

	layers[1].size = nr_channels;

	layers[1].is_virt_csrow = false;

	mci = edac_mc_alloc(0, ARRAY_SIZE(layers), layers,

			    sizeof(struct i3200_priv));



	rc = -ENOMEM;

	mci = edac_mc_alloc(0, ARRAY_SIZE(layers), layers, sizeof(struct i3200_priv));

	if (!mci)

		return -ENOMEM;

		goto unmap;



	edac_dbg(3, "MC: init mci\n");
@@ -421,9 +422,9 @@ static int i3200_probe1(struct pci_dev *pdev, int dev_idx) 
	return 0;



fail:

	iounmap(window);

	if (mci)

	edac_mc_free(mci);

unmap:

	iounmap(window);



	return rc;

}