Unverified Commit d450cdd9 authored by Gabor Juhos's avatar Gabor Juhos Committed by Mark Brown
Browse files

spi: spi-qpic-snand: avoid memleak in qcom_spi_ecc_init_ctx_pipelined() 



When the allocation of the OOB buffer fails, the
qcom_spi_ecc_init_ctx_pipelined() function returns without freeing
the memory allocated for 'ecc_cfg' thus it can cause a memory leak.

Call kfree() to free 'ecc_cfg' before returning from the function
to avoid that.

Fixes: 7304d190 ("spi: spi-qpic: add driver for QCOM SPI NAND flash Interface")
Signed-off-by: default avatarGabor Juhos <j4g8y7@gmail.com>
Link: https://patch.msgid.link/20250313-qpic-snand-memleak-fix-v1-1-e54e78d1da3a@gmail.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 5a5fc308

drivers/spi/spi-qpic-snand.c

+3 −1
Original line number Diff line number Diff line
@@ -263,8 +263,10 @@ static int qcom_spi_ecc_init_ctx_pipelined(struct nand_device *nand) 
		return -ENOMEM;

	snandc->qspi->oob_buf = kzalloc(mtd->writesize + mtd->oobsize,

					GFP_KERNEL);

	if (!snandc->qspi->oob_buf)

	if (!snandc->qspi->oob_buf) {

		kfree(ecc_cfg);

		return -ENOMEM;

	}



	memset(snandc->qspi->oob_buf, 0xff, mtd->writesize + mtd->oobsize);