Commit d45dda49 authored by Jacek Kowalski's avatar Jacek Kowalski Committed by Tony Nguyen
Browse files

igc: drop unnecessary constant casts to u16 



Remove unnecessary casts of constant values to u16.
C's integer promotion rules make them ints no matter what.

Signed-off-by: default avatarJacek Kowalski <jacek@jacekk.info>
Suggested-by: default avatarSimon Horman <horms@kernel.org>
Reviewed-by: default avatarAleksandr Loktionov <aleksandr.loktionov@intel.com>
Reviewed-by: default avatarSimon Horman <horms@kernel.org>
Signed-off-by: default avatarTony Nguyen <anthony.l.nguyen@intel.com>
parent b45d082d

drivers/net/ethernet/intel/igc/igc_i225.c

+1 −1
Original line number Diff line number Diff line
@@ -435,7 +435,7 @@ static s32 igc_update_nvm_checksum_i225(struct igc_hw *hw) 
		}

		checksum += nvm_data;

	}

	checksum = (u16)NVM_SUM - checksum;

	checksum = NVM_SUM - checksum;

	ret_val = igc_write_nvm_srwr(hw, NVM_CHECKSUM_REG, 1,

				     &checksum);

	if (ret_val) {

drivers/net/ethernet/intel/igc/igc_nvm.c

+2 −2
Original line number Diff line number Diff line
@@ -123,7 +123,7 @@ s32 igc_validate_nvm_checksum(struct igc_hw *hw) 
		checksum += nvm_data;

	}



	if (checksum != (u16)NVM_SUM) {

	if (checksum != NVM_SUM) {

		hw_dbg("NVM Checksum Invalid\n");

		ret_val = -IGC_ERR_NVM;

		goto out;
@@ -155,7 +155,7 @@ s32 igc_update_nvm_checksum(struct igc_hw *hw) 
		}

		checksum += nvm_data;

	}

	checksum = (u16)NVM_SUM - checksum;

	checksum = NVM_SUM - checksum;

	ret_val = hw->nvm.ops.write(hw, NVM_CHECKSUM_REG, 1, &checksum);

	if (ret_val)

		hw_dbg("NVM Write Error while updating checksum.\n");