Commit d469eaed authored by Eric Biggers's avatar Eric Biggers Committed by Herbert Xu
Browse files

crypto: testmgr - remove panic_on_fail 



The cryptomgr.panic_on_fail=1 kernel command-line parameter is not very
useful now that the tests have been fixed to WARN on failure, since
developers can just use panic_on_warn=1 instead.  There's no need for a
special option just for the crypto self-tests.  Remove it.

Signed-off-by: default avatarEric Biggers <ebiggers@google.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent 3357b6c9

crypto/testmgr.c

+3 −7
Original line number Diff line number Diff line
@@ -45,9 +45,6 @@ static bool notests; 
module_param(notests, bool, 0644);

MODULE_PARM_DESC(notests, "disable crypto self-tests");



static bool panic_on_fail;

module_param(panic_on_fail, bool, 0444);



#ifdef CONFIG_CRYPTO_MANAGER_EXTRA_TESTS

static bool noextratests;

module_param(noextratests, bool, 0644);
@@ -5854,11 +5851,10 @@ int alg_test(const char *driver, const char *alg, u32 type, u32 mask) 


test_done:

	if (rc) {

		if (fips_enabled || panic_on_fail) {

		if (fips_enabled) {

			fips_fail_notify();

			panic("alg: self-tests for %s (%s) failed in %s mode!\n",

			      driver, alg,

			      fips_enabled ? "fips" : "panic_on_fail");

			panic("alg: self-tests for %s (%s) failed in fips mode!\n",

			      driver, alg);

		}

		pr_warn("alg: self-tests for %s using %s failed (rc=%d)",

			alg, driver, rc);