Commit d46c4c83 authored Jun 03, 2025 by Rafael J. Wysocki

PM: sleep: Fix power.is_suspended cleanup for direct-complete devices

Commit 03f14440 ("PM: sleep: Fix handling devices with direct_complete
set on errors") caused power.is_suspended to be set for devices with
power.direct_complete set, but it forgot to ensure the clearing of that
flag for them in device_resume(), so power.is_suspended is still set for
them during the next system suspend-resume cycle.

If that cycle is aborted in dpm_suspend(), the subsequent invocation of
dpm_resume() will trigger a device_resume() call for every device and
because power.is_suspended is set for the devices in question, they will
not be skipped by device_resume() as expected which causes scary error
messages to be logged (as appropriate).

To address this issue, move the clearing of power.is_suspended in
device_resume() immediately after the power.is_suspended check so it
will be always cleared for all devices processed by that function.

Fixes: 03f14440 ("PM: sleep: Fix handling devices with direct_complete set on errors")
Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/4280

Reported-and-tested-by: Chris Bainbridge <chris.bainbridge@gmail.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
Link: https://patch.msgid.link/4990586.GXAFRqVoOG@rjwysocki.net

parent 079e8889

drivers/base/power/main.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -985,6 +985,8 @@ static void device_resume(struct device *dev, pm_message_t state, bool async)
		if (!dev->power.is_suspended)
		goto Complete;

		dev->power.is_suspended = false;

		if (dev->power.direct_complete) {
		/*
		* Allow new children to be added under the device after this
		@@ -1047,7 +1049,6 @@ static void device_resume(struct device *dev, pm_message_t state, bool async)

		End:
		error = dpm_run_callback(callback, dev, state, info);
		dev->power.is_suspended = false;

		device_unlock(dev);
		dpm_watchdog_clear(&wd);