Commit d4c08d8b authored by Dmitry Baryshkov's avatar Dmitry Baryshkov Committed by Vinod Koul
Browse files

phy: qcom-qmp-usb: fix v3 offsets data 



The MSM8996 platform has registers setup different to the rest of QMP v3
USB platforms. It has PCS region at 0x600 and no PCS_MISC region, while
other platforms have PCS region at 0x800 and PCS_MISC at 0x600.  This
results in the malfunctioning USB host on some of the platforms.  The
commit f74c35b6 ("phy: qcom-qmp-usb: fix register offsets for
ipq8074/ipq6018") fixed the issue for IPQ platforms, but missed the
SDM845 which has the same register layout.

To simplify future platform addition and to make the driver more future
proof, rename qmp_usb_offsets_v3 to qmp_usb_offsets_v3_msm8996 (to mark
its peculiarity), rename qmp_usb_offsets_ipq8074 to qmp_usb_offsets_v3
and use it for SDM845 platform.

Fixes: 2be22aae ("phy: qcom-qmp-usb: populate offsets configuration")
Signed-off-by: default avatarDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Link: https://lore.kernel.org/r/20240213133824.2218916-1-dmitry.baryshkov@linaro.org


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent 734550d6

drivers/phy/qualcomm/phy-qcom-qmp-usb.c

+5 −5
Original line number Diff line number Diff line
@@ -1556,7 +1556,7 @@ static const char * const qmp_phy_vreg_l[] = { 
	"vdda-phy", "vdda-pll",

};



static const struct qmp_usb_offsets qmp_usb_offsets_ipq8074 = {

static const struct qmp_usb_offsets qmp_usb_offsets_v3 = {

	.serdes		= 0,

	.pcs		= 0x800,

	.pcs_misc	= 0x600,
@@ -1572,7 +1572,7 @@ static const struct qmp_usb_offsets qmp_usb_offsets_ipq9574 = { 
	.rx		= 0x400,

};



static const struct qmp_usb_offsets qmp_usb_offsets_v3 = {

static const struct qmp_usb_offsets qmp_usb_offsets_v3_msm8996 = {

	.serdes		= 0,

	.pcs		= 0x600,

	.tx		= 0x200,
@@ -1624,7 +1624,7 @@ static const struct qmp_usb_offsets qmp_usb_offsets_v7 = { 
static const struct qmp_phy_cfg ipq6018_usb3phy_cfg = {

	.lanes			= 1,



	.offsets		= &qmp_usb_offsets_ipq8074,

	.offsets		= &qmp_usb_offsets_v3,



	.serdes_tbl		= ipq9574_usb3_serdes_tbl,

	.serdes_tbl_num		= ARRAY_SIZE(ipq9574_usb3_serdes_tbl),
@@ -1642,7 +1642,7 @@ static const struct qmp_phy_cfg ipq6018_usb3phy_cfg = { 
static const struct qmp_phy_cfg ipq8074_usb3phy_cfg = {

	.lanes			= 1,



	.offsets		= &qmp_usb_offsets_ipq8074,

	.offsets		= &qmp_usb_offsets_v3,



	.serdes_tbl		= ipq8074_usb3_serdes_tbl,

	.serdes_tbl_num		= ARRAY_SIZE(ipq8074_usb3_serdes_tbl),
@@ -1678,7 +1678,7 @@ static const struct qmp_phy_cfg ipq9574_usb3phy_cfg = { 
static const struct qmp_phy_cfg msm8996_usb3phy_cfg = {

	.lanes			= 1,



	.offsets		= &qmp_usb_offsets_v3,

	.offsets		= &qmp_usb_offsets_v3_msm8996,



	.serdes_tbl		= msm8996_usb3_serdes_tbl,

	.serdes_tbl_num		= ARRAY_SIZE(msm8996_usb3_serdes_tbl),