Unverified Commit d4e88bb0 authored by Joanne Koong's avatar Joanne Koong Committed by Christian Brauner
Browse files

iomap: make iomap_read_folio() a void return 



No errors are propagated in iomap_read_folio(). Change
iomap_read_folio() to a void return to make this clearer to callers.

Signed-off-by: default avatarJoanne Koong <joannelkoong@gmail.com>
Reviewed-by: default avatarDarrick J. Wong <djwong@kernel.org>
Signed-off-by: default avatarChristian Brauner <brauner@kernel.org>
parent c2b1adc4

fs/iomap/buffered-io.c

+1 −8
Original line number Diff line number Diff line
@@ -495,7 +495,7 @@ static int iomap_read_folio_iter(struct iomap_iter *iter, 
	return 0;

}



int iomap_read_folio(const struct iomap_ops *ops,

void iomap_read_folio(const struct iomap_ops *ops,

		struct iomap_read_folio_ctx *ctx)

{

	struct folio *folio = ctx->cur_folio;
@@ -516,13 +516,6 @@ int iomap_read_folio(const struct iomap_ops *ops, 
		ctx->ops->submit_read(ctx);



	iomap_read_end(folio, bytes_pending);



	/*

	 * Just like mpage_readahead and block_read_full_folio, we always

	 * return 0 and just set the folio error flag on errors.  This

	 * should be cleaned up throughout the stack eventually.

	 */

	return 0;

}

EXPORT_SYMBOL_GPL(iomap_read_folio);

include/linux/iomap.h

+1 −1
Original line number Diff line number Diff line
@@ -338,7 +338,7 @@ static inline bool iomap_want_unshare_iter(const struct iomap_iter *iter) 
ssize_t iomap_file_buffered_write(struct kiocb *iocb, struct iov_iter *from,

		const struct iomap_ops *ops,

		const struct iomap_write_ops *write_ops, void *private);

int iomap_read_folio(const struct iomap_ops *ops,

void iomap_read_folio(const struct iomap_ops *ops,

		struct iomap_read_folio_ctx *ctx);

void iomap_readahead(const struct iomap_ops *ops,

		struct iomap_read_folio_ctx *ctx);