Commit d5409ebf authored by Christoph Hellwig's avatar Christoph Hellwig Committed by Carlos Maiolino
Browse files

xfs: remove xfs_errortag_get 



xfs_errortag_get is only called by xfs_errortag_attr_show, which does not
need to validate the error tag, because it can only be called on valid
error tags that had a sysfs attribute registered.

Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
Reviewed-by: default avatarDarrick J. Wong <djwong@kernel.org>
Signed-off-by: default avatarCarlos Maiolino <cem@kernel.org>
parent 42c21838

fs/xfs/xfs_error.c

+2 −14
Original line number Diff line number Diff line
@@ -118,10 +118,9 @@ xfs_errortag_attr_show( 
	char			*buf)

{

	struct xfs_mount	*mp = to_mp(kobject);

	struct xfs_errortag_attr *xfs_attr = to_attr(attr);

	unsigned int		error_tag = to_attr(attr)->tag;



	return snprintf(buf, PAGE_SIZE, "%u\n",

			xfs_errortag_get(mp, xfs_attr->tag));

	return snprintf(buf, PAGE_SIZE, "%u\n", mp->m_errortag[error_tag]);

}



static const struct sysfs_ops xfs_errortag_sysfs_ops = {
@@ -326,17 +325,6 @@ xfs_errortag_test( 
	return true;

}



int

xfs_errortag_get(

	struct xfs_mount	*mp,

	unsigned int		error_tag)

{

	if (!xfs_errortag_valid(error_tag))

		return -EINVAL;



	return mp->m_errortag[error_tag];

}



int

xfs_errortag_set(

	struct xfs_mount	*mp,

fs/xfs/xfs_error.h

+0 −1
Original line number Diff line number Diff line
@@ -58,7 +58,6 @@ bool xfs_errortag_enabled(struct xfs_mount *mp, unsigned int tag); 
		mdelay((mp)->m_errortag[(tag)]); \

	} while (0)



extern int xfs_errortag_get(struct xfs_mount *mp, unsigned int error_tag);

extern int xfs_errortag_set(struct xfs_mount *mp, unsigned int error_tag,

		unsigned int tag_value);

extern int xfs_errortag_add(struct xfs_mount *mp, unsigned int error_tag);