Commit d563e7f9 authored by Alexander Stein's avatar Alexander Stein Committed by Bartosz Golaszewski
Browse files

gpio: of: initialize local variable passed to the .of_xlate() callback 



of_flags is passed down to GPIO chip's xlate function, so ensure this one
is properly initialized as - if the xlate callback does nothing with it
- we may end up with various configuration errors like:

    gpio-720 (enable): multiple pull-up, pull-down or pull-disable enabled, invalid configuration

Signed-off-by: default avatarAlexander Stein <alexander.stein@ew.tq-group.com>
Link: https://lore.kernel.org/r/20250708083829.658051-1-alexander.stein@ew.tq-group.com


[Bartosz: tweaked the commit message]
Signed-off-by: default avatarBartosz Golaszewski <bartosz.golaszewski@linaro.org>
parent 30e0fd3c

drivers/gpio/gpiolib-of.c

+1 −1
Original line number Diff line number Diff line
@@ -708,7 +708,7 @@ struct gpio_desc *of_find_gpio(struct device_node *np, const char *con_id, 
			       unsigned int idx, unsigned long *flags)

{

	char propname[32]; /* 32 is max size of property name */

	enum of_gpio_flags of_flags;

	enum of_gpio_flags of_flags = 0;

	const of_find_gpio_quirk *q;

	struct gpio_desc *desc;