Commit d5734302 authored by Chanho Park's avatar Chanho Park Committed by Herbert Xu
Browse files

crypto: jh7110 - Correct deferred probe return



This fixes list_add corruption error when the driver is returned
with -EPROBE_DEFER. It is also required to roll back the previous
probe sequences in case of deferred_probe. So, this removes
'err_probe_defer" goto label and just use err_dma_init instead.

Fixes: 42ef0e94 ("crypto: starfive - Add crypto engine support")
Signed-off-by: default avatarChanho Park <chanho61.park@samsung.com>
Reviewed-by: default avatarJia Jie Ho <jiajie.ho@starfivetech.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent ba5a434d
Loading
Loading
Loading
Loading
+3 −7
Original line number Diff line number Diff line
@@ -180,12 +180,8 @@ static int starfive_cryp_probe(struct platform_device *pdev)
	spin_unlock(&dev_list.lock);

	ret = starfive_dma_init(cryp);
	if (ret) {
		if (ret == -EPROBE_DEFER)
			goto err_probe_defer;
		else
	if (ret)
		goto err_dma_init;
	}

	/* Initialize crypto engine */
	cryp->engine = crypto_engine_alloc_init(&pdev->dev, 1);
@@ -233,7 +229,7 @@ static int starfive_cryp_probe(struct platform_device *pdev)

	tasklet_kill(&cryp->aes_done);
	tasklet_kill(&cryp->hash_done);
err_probe_defer:

	return ret;
}