Unverified Commit d581fc99 authored by David Carlier's avatar David Carlier Committed by Pasha Tatashin
Browse files

mm/memfd_luo: reject memfds whose page count exceeds UINT_MAX 



memfd_luo_preserve_folios() declares max_folios as unsigned int and
computes it from the inode size, then passes it to memfd_pin_folios()
which itself caps max_folios at unsigned int.  For files whose base-page
count exceeds UINT_MAX (larger than 16 TiB with 4 KiB pages), the
assignment truncates silently: only a prefix of the file gets pinned and
preserved, while memfd_luo_preserve() still records the full inode size
in ser->size.  On retrieve the inode is restored to the full size but
only the preserved prefix repopulates the page cache, so the tail comes
back as holes and user data is silently lost across the live update.

Reject such files at preserve time with -EFBIG rather than chunk the
pin loop, which would also require enlarging the preserved folios array
well beyond what is practical.

Fixes: b3749f17 ("mm: memfd_luo: allow preserving memfd")
Signed-off-by: default avatarDavid Carlier <devnexen@gmail.com>
Reviewed-by: default avatarPasha Tatashin <pasha.tatashin@soleen.com>
Reviewed-by: default avatarPratyush Yadav <pratyush@kernel.org>
Link: https://patch.msgid.link/20260423125648.152113-1-devnexen@gmail.com


Signed-off-by: default avatarPasha Tatashin <pasha.tatashin@soleen.com>
parent 0fb1daf0

mm/memfd_luo.c

+13 −2
Original line number Diff line number Diff line
@@ -259,7 +259,7 @@ static int memfd_luo_preserve(struct liveupdate_file_op_args *args) 
	struct inode *inode = file_inode(args->file);

	struct memfd_luo_folio_ser *folios_ser;

	struct memfd_luo_ser *ser;

	u64 nr_folios;

	u64 nr_folios, inode_size;

	int err = 0, seals;



	inode_lock(inode);
@@ -285,7 +285,18 @@ static int memfd_luo_preserve(struct liveupdate_file_op_args *args) 
	}



	ser->pos = args->file->f_pos;

	ser->size = i_size_read(inode);

	inode_size = i_size_read(inode);



	/*

	 * memfd_pin_folios() caps at UINT_MAX folios; refuse larger

	 * files to avoid silently preserving only a prefix.

	 */

	if (DIV_ROUND_UP_ULL(inode_size, PAGE_SIZE) > UINT_MAX) {

		err = -EFBIG;

		goto err_free_ser;

	}



	ser->size = inode_size;

	ser->seals = seals;



	err = memfd_luo_preserve_folios(args->file, &ser->folios,