Commit d59d844e authored by Qiuxu Zhuo's avatar Qiuxu Zhuo Committed by Tony Luck
Browse files

EDAC/ie31200: Fix the size of EDAC_MC_LAYER_CHIP_SELECT layer 



The EDAC_MC_LAYER_CHIP_SELECT layer pertains to the rank, not the DIMM.
Fix its size to reflect the number of ranks instead of the number of DIMMs.
Also delete the unused macros IE31200_{DIMMS,RANKS}.

Fixes: 7ee40b89 ("ie31200_edac: Introduce the driver")
Signed-off-by: default avatarQiuxu Zhuo <qiuxu.zhuo@intel.com>
Signed-off-by: default avatarTony Luck <tony.luck@intel.com>
Tested-by: default avatarGary Wang <gary.c.wang@intel.com>
Link: https://lore.kernel.org/r/20250310011411.31685-2-qiuxu.zhuo@intel.com
parent d9207cf7

drivers/edac/ie31200_edac.c

+1 −3
Original line number Diff line number Diff line
@@ -94,8 +94,6 @@ 
	 (((did) & PCI_DEVICE_ID_INTEL_IE31200_HB_CFL_MASK) ==                 \

	  PCI_DEVICE_ID_INTEL_IE31200_HB_CFL_MASK))



#define IE31200_DIMMS			4

#define IE31200_RANKS			8

#define IE31200_RANKS_PER_CHANNEL	4

#define IE31200_DIMMS_PER_CHANNEL	2

#define IE31200_CHANNELS		2
@@ -428,7 +426,7 @@ static int ie31200_probe1(struct pci_dev *pdev, int dev_idx) 


	nr_channels = how_many_channels(pdev);

	layers[0].type = EDAC_MC_LAYER_CHIP_SELECT;

	layers[0].size = IE31200_DIMMS;

	layers[0].size = IE31200_RANKS_PER_CHANNEL;

	layers[0].is_virt_csrow = true;

	layers[1].type = EDAC_MC_LAYER_CHANNEL;

	layers[1].size = nr_channels;