Commit d5a590b1 authored by Russell King (Oracle)'s avatar Russell King (Oracle) Committed by Jakub Kicinski
Browse files

net: dsa: mt753x: remove mt753x_phylink_pcs_link_up() 



Remove the mt753x_phylink_pcs_link_up() function for two reasons:

1) priv->pcs[i].pcs.neg_mode is set true, meaning it doesn't take a
   MLO_AN_FIXED anymore, but one of PHYLINK_PCS_NEG_*. However, this
   is inconsequential due to...
2) priv->pcs[port].pcs.ops is always initialised to point at
   mt7530_pcs_ops, which does not have a pcs_link_up() member.

So, let's remove mt753x_phylink_pcs_link_up() entirely.

Signed-off-by: default avatarRussell King (Oracle) <rmk+kernel@armlinux.org.uk>
Reviewed-by: default avatarVladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: default avatarFlorian Fainelli <florian.fainelli@broadcom.com>
Link: https://lore.kernel.org/r/E1qlTQS-008BWe-Va@rmk-PC.armlinux.org.uk


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 00f3696f

drivers/net/dsa/mt7530.c

+0 −11
Original line number Diff line number Diff line
@@ -2824,15 +2824,6 @@ static void mt753x_phylink_mac_link_down(struct dsa_switch *ds, int port, 
	mt7530_clear(priv, MT7530_PMCR_P(port), PMCR_LINK_SETTINGS_MASK);

}



static void mt753x_phylink_pcs_link_up(struct phylink_pcs *pcs,

				       unsigned int mode,

				       phy_interface_t interface,

				       int speed, int duplex)

{

	if (pcs->ops->pcs_link_up)

		pcs->ops->pcs_link_up(pcs, mode, interface, speed, duplex);

}



static void mt753x_phylink_mac_link_up(struct dsa_switch *ds, int port,

				       unsigned int mode,

				       phy_interface_t interface,
@@ -2921,8 +2912,6 @@ mt7531_cpu_port_config(struct dsa_switch *ds, int port) 
		return ret;

	mt7530_write(priv, MT7530_PMCR_P(port),

		     PMCR_CPU_PORT_SETTING(priv->id));

	mt753x_phylink_pcs_link_up(&priv->pcs[port].pcs, MLO_AN_FIXED,

				   interface, speed, DUPLEX_FULL);

	mt753x_phylink_mac_link_up(ds, port, MLO_AN_FIXED, interface, NULL,

				   speed, DUPLEX_FULL, true, true);