Commit d5c17e36 authored by Vladimir Oltean's avatar Vladimir Oltean Committed by Jakub Kicinski
Browse files

docs: networking: timestamping: improve stacked PHC sentence 



The first paragraph makes no grammatical sense. I suppose a portion of
the intended sentece is missing: "[The challenge with ] stacked PHCs
(...) is that they uncover bugs".

Rephrase, and at the same time simplify the structure of the sentence a
little bit, it is not easy to follow.

Fixes: 94d9f78f ("docs: networking: timestamping: add section for stacked PHC devices")
Signed-off-by: default avatarVladimir Oltean <vladimir.oltean@nxp.com>
Acked-by: default avatarRichard Cochran <richardcochran@gmail.com>
Link: https://patch.msgid.link/20250512131751.320283-1-vladimir.oltean@nxp.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 58843147

Documentation/networking/timestamping.rst

+3 −5
Original line number Diff line number Diff line
@@ -811,11 +811,9 @@ Documentation/devicetree/bindings/ptp/timestamper.txt for more details. 
3.2.4 Other caveats for MAC drivers

^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^



Stacked PHCs, especially DSA (but not only) - since that doesn't require any

modification to MAC drivers, so it is more difficult to ensure correctness of

all possible code paths - is that they uncover bugs which were impossible to

trigger before the existence of stacked PTP clocks.  One example has to do with

this line of code, already presented earlier::

The use of stacked PHCs may uncover MAC driver bugs which were impossible to

trigger without them. One example has to do with this line of code, already

presented earlier::



      skb_shinfo(skb)->tx_flags |= SKBTX_IN_PROGRESS;