Unverified Commit d5cda96d authored by Srinivas Kandagatla's avatar Srinivas Kandagatla Committed by Mark Brown
Browse files

ASoC: codecs: wcd938x-sdw: remove redundant runtime pm calls 



Component bind callbacks already does runtime pm calls, soundwire codec
also tries to do the exactly same thing resulting in Unbalanced
pm_runtime_enable and disable calls.

Remove the redundant calls from wcd938x-sdw driver.

Reported-by: default avatarKonrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Fixes: ebaf88c0 ("ASoC: codecs: wcd-common: move component ops to common")
Signed-off-by: default avatarSrinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
Link: https://patch.msgid.link/20251008145801.3479-1-srinivas.kandagatla@oss.qualcomm.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 57b00ab3

sound/soc/codecs/wcd938x-sdw.c

+3 −17
Original line number Diff line number Diff line
@@ -1207,24 +1207,14 @@ static int wcd9380_probe(struct sdw_slave *pdev, 
		regcache_cache_only(wcd->regmap, true);

	}



	pm_runtime_set_autosuspend_delay(dev, 3000);

	pm_runtime_use_autosuspend(dev);

	pm_runtime_mark_last_busy(dev);

	pm_runtime_set_active(dev);

	pm_runtime_enable(dev);



	ret = component_add(dev, &wcd_sdw_component_ops);

	if (ret)

		goto err_disable_rpm;



	return 0;

		return ret;



err_disable_rpm:

	pm_runtime_disable(dev);

	/* Set suspended until aggregate device is bind */

	pm_runtime_set_suspended(dev);

	pm_runtime_dont_use_autosuspend(dev);



	return ret;

	return 0;

}



static int wcd9380_remove(struct sdw_slave *pdev)
@@ -1233,10 +1223,6 @@ static int wcd9380_remove(struct sdw_slave *pdev) 


	component_del(dev, &wcd_sdw_component_ops);



	pm_runtime_disable(dev);

	pm_runtime_set_suspended(dev);

	pm_runtime_dont_use_autosuspend(dev);



	return 0;

}