Commit d5e4e147 authored by Baolin Wang's avatar Baolin Wang Committed by Andrew Morton
Browse files

mm: shmem: remove duplicate error validation 

Remove duplicate error code checks for 'start' and 'end', as the
get_order_from_str() will only return -EINVAL if the cmdline string is
configured incorrectly.

Link: https://lkml.kernel.org/r/dfadaba4c8b24c5ae1467fe8b6744b654c65ec91.1738918357.git.baolin.wang@linux.alibaba.com


Signed-off-by: default avatarBaolin Wang <baolin.wang@linux.alibaba.com>
Cc: David Hildenbrand <david@redhat.com>
Cc: Hugh Dickins <hughd@google.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent 6d26a149

mm/shmem.c

+3 −3
Original line number Diff line number Diff line
@@ -5664,19 +5664,19 @@ static int __init setup_thp_shmem(char *str) 
								 THP_ORDERS_ALL_FILE_DEFAULT);

			}



			if (start == -EINVAL) {

			if (start < 0) {

				pr_err("invalid size %s in thp_shmem boot parameter\n",

				       start_size);

				goto err;

			}



			if (end == -EINVAL) {

			if (end < 0) {

				pr_err("invalid size %s in thp_shmem boot parameter\n",

				       end_size);

				goto err;

			}



			if (start < 0 || end < 0 || start > end)

			if (start > end)

				goto err;



			nr = end - start + 1;