Commit d68fc95a authored by Francis Pravin's avatar Francis Pravin Committed by Keith Busch
Browse files

nvme-pci: remove redundant dma frees in hmb 



The value of size is 0 when there is no dma buffer allocated. The value
of i also remains 0. So, no need to free the dma buffer in out_free_bufs.
Hence, remove the redundant dma frees.

Signed-off-by: default avatarFrancis Pravin <francis.p@samsung.com>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarKeith Busch <kbusch@kernel.org>
parent 3c47c2cc

drivers/nvme/host/pci.c

+0 −8
Original line number Diff line number Diff line
@@ -2153,14 +2153,6 @@ static int nvme_alloc_host_mem_multi(struct nvme_dev *dev, u64 preferred, 
	return 0;



out_free_bufs:

	while (--i >= 0) {

		size_t size = le32_to_cpu(descs[i].size) * NVME_CTRL_PAGE_SIZE;



		dma_free_attrs(dev->dev, size, bufs[i],

			       le64_to_cpu(descs[i].addr),

			       DMA_ATTR_NO_KERNEL_MAPPING | DMA_ATTR_NO_WARN);

	}



	kfree(bufs);

out_free_descs:

	dma_free_coherent(dev->dev, descs_size, descs, descs_dma);