Commit d6a4da52 authored by Tejas Vipin's avatar Tejas Vipin Committed by Neil Armstrong
Browse files

drm/panel: panel-samsung-sofef00: transition to mipi_dsi wrapped functions 



Changes the samsung-sofef00 panel to use multi style functions for
improved error handling.

Signed-off-by: default avatarTejas Vipin <tejasvipin76@gmail.com>
Reviewed-by: default avatarDmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20250419041210.515517-2-tejasvipin76@gmail.com


Signed-off-by: default avatarNeil Armstrong <neil.armstrong@linaro.org>
Link: https://lore.kernel.org/r/20250419041210.515517-2-tejasvipin76@gmail.com
parent a49ce9cc

drivers/gpu/drm/panel/panel-samsung-sofef00.c

+21 −49
Original line number Diff line number Diff line
@@ -44,66 +44,44 @@ static void sofef00_panel_reset(struct sofef00_panel *ctx) 
static int sofef00_panel_on(struct sofef00_panel *ctx)

{

	struct mipi_dsi_device *dsi = ctx->dsi;

	struct device *dev = &dsi->dev;

	int ret;

	struct mipi_dsi_multi_context dsi_ctx = { .dsi = dsi };



	dsi->mode_flags |= MIPI_DSI_MODE_LPM;



	ret = mipi_dsi_dcs_exit_sleep_mode(dsi);

	if (ret < 0) {

		dev_err(dev, "Failed to exit sleep mode: %d\n", ret);

		return ret;

	}

	usleep_range(10000, 11000);

	mipi_dsi_dcs_exit_sleep_mode_multi(&dsi_ctx);

	mipi_dsi_usleep_range(&dsi_ctx, 10000, 11000);



	mipi_dsi_dcs_write_seq(dsi, 0xf0, 0x5a, 0x5a);

	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xf0, 0x5a, 0x5a);



	ret = mipi_dsi_dcs_set_tear_on(dsi, MIPI_DSI_DCS_TEAR_MODE_VBLANK);

	if (ret < 0) {

		dev_err(dev, "Failed to set tear on: %d\n", ret);

		return ret;

	}

	mipi_dsi_dcs_set_tear_on_multi(&dsi_ctx, MIPI_DSI_DCS_TEAR_MODE_VBLANK);



	mipi_dsi_dcs_write_seq(dsi, 0xf0, 0xa5, 0xa5);

	mipi_dsi_dcs_write_seq(dsi, 0xf0, 0x5a, 0x5a);

	mipi_dsi_dcs_write_seq(dsi, 0xb0, 0x07);

	mipi_dsi_dcs_write_seq(dsi, 0xb6, 0x12);

	mipi_dsi_dcs_write_seq(dsi, 0xf0, 0xa5, 0xa5);

	mipi_dsi_dcs_write_seq(dsi, MIPI_DCS_WRITE_CONTROL_DISPLAY, 0x20);

	mipi_dsi_dcs_write_seq(dsi, MIPI_DCS_WRITE_POWER_SAVE, 0x00);

	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xf0, 0xa5, 0xa5);

	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xf0, 0x5a, 0x5a);

	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xb0, 0x07);

	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xb6, 0x12);

	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xf0, 0xa5, 0xa5);

	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, MIPI_DCS_WRITE_CONTROL_DISPLAY, 0x20);

	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, MIPI_DCS_WRITE_POWER_SAVE, 0x00);



	ret = mipi_dsi_dcs_set_display_on(dsi);

	if (ret < 0) {

		dev_err(dev, "Failed to set display on: %d\n", ret);

		return ret;

	}

	mipi_dsi_dcs_set_display_on_multi(&dsi_ctx);



	return 0;

	return dsi_ctx.accum_err;

}



static int sofef00_panel_off(struct sofef00_panel *ctx)

{

	struct mipi_dsi_device *dsi = ctx->dsi;

	struct device *dev = &dsi->dev;

	int ret;

	struct mipi_dsi_multi_context dsi_ctx = { .dsi = dsi };



	dsi->mode_flags &= ~MIPI_DSI_MODE_LPM;



	ret = mipi_dsi_dcs_set_display_off(dsi);

	if (ret < 0) {

		dev_err(dev, "Failed to set display off: %d\n", ret);

		return ret;

	}

	msleep(40);

	mipi_dsi_dcs_set_display_off_multi(&dsi_ctx);

	mipi_dsi_msleep(&dsi_ctx, 40);



	ret = mipi_dsi_dcs_enter_sleep_mode(dsi);

	if (ret < 0) {

		dev_err(dev, "Failed to enter sleep mode: %d\n", ret);

		return ret;

	}

	msleep(160);

	mipi_dsi_dcs_enter_sleep_mode_multi(&dsi_ctx);

	mipi_dsi_msleep(&dsi_ctx, 160);



	return 0;

	return dsi_ctx.accum_err;

}



static int sofef00_panel_prepare(struct drm_panel *panel)
@@ -122,7 +100,6 @@ static int sofef00_panel_prepare(struct drm_panel *panel) 


	ret = sofef00_panel_on(ctx);

	if (ret < 0) {

		dev_err(dev, "Failed to initialize panel: %d\n", ret);

		gpiod_set_value_cansleep(ctx->reset_gpio, 1);

		return ret;

	}
@@ -133,13 +110,8 @@ static int sofef00_panel_prepare(struct drm_panel *panel) 
static int sofef00_panel_unprepare(struct drm_panel *panel)

{

	struct sofef00_panel *ctx = to_sofef00_panel(panel);

	struct device *dev = &ctx->dsi->dev;

	int ret;



	ret = sofef00_panel_off(ctx);

	if (ret < 0)

		dev_err(dev, "Failed to un-initialize panel: %d\n", ret);



	sofef00_panel_off(ctx);

	regulator_disable(ctx->supply);



	return 0;