Commit d6ff6e87 authored by Alexandre Courbot's avatar Alexandre Courbot Committed by Miguel Ojeda
Browse files

rust: sync: refcount: always inline functions using build_assert with arguments 



`build_assert` relies on the compiler to optimize out its error path.
Functions using it with its arguments must thus always be inlined,
otherwise the error path of `build_assert` might not be optimized out,
triggering a build error.

Cc: stable@vger.kernel.org
Fixes: bb38f35b ("rust: implement `kernel::sync::Refcount`")
Reviewed-by: default avatarDaniel Almeida <daniel.almeida@collabora.com>
Signed-off-by: default avatarAlexandre Courbot <acourbot@nvidia.com>
Acked-by: default avatarBoqun Feng <boqun.feng@gmail.com>
Link: https://patch.msgid.link/20251208-io-build-assert-v3-5-98aded02c1ea@nvidia.com


Signed-off-by: default avatarMiguel Ojeda <ojeda@kernel.org>
parent 09c3c911

rust/kernel/sync/refcount.rs

+2 −1
Original line number Diff line number Diff line
@@ -23,7 +23,8 @@ impl Refcount { 
    /// Construct a new [`Refcount`] from an initial value.

    ///

    /// The initial value should be non-saturated.

    #[inline]

    // Always inline to optimize out error path of `build_assert`.

    #[inline(always)]

    pub fn new(value: i32) -> Self {

        build_assert!(value >= 0, "initial value saturated");

        // SAFETY: There are no safety requirements for this FFI call.