Commit d700b2a4 authored by Sean Anderson's avatar Sean Anderson Committed by Jakub Kicinski
Browse files

net: phy: dp83867: Program TX FIFO for all interfaces 



All supported interfaces use the TX FIFO register at least some of the
time, so there's no point in checking the interface. Retain the check
for the RX FIFO level since it is only used by SGMII.

Signed-off-by: default avatarSean Anderson <sean.anderson@linux.dev>
Link: https://patch.msgid.link/20260129171205.3868605-2-sean.anderson@linux.dev


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 82f35bec

drivers/net/phy/dp83867.c

+14 −17
Original line number Diff line number Diff line
@@ -744,8 +744,6 @@ static int dp83867_config_init(struct phy_device *phydev) 
	 */

	phy_disable_eee(phydev);



	if (phy_interface_is_rgmii(phydev) ||

	    phydev->interface == PHY_INTERFACE_MODE_SGMII) {

	val = phy_read(phydev, MII_DP83867_PHYCTRL);

	if (val < 0)

		return val;
@@ -763,7 +761,6 @@ static int dp83867_config_init(struct phy_device *phydev) 
	ret = phy_write(phydev, MII_DP83867_PHYCTRL, val);

	if (ret)

		return ret;

	}



	if (phy_interface_is_rgmii(phydev)) {

		val = phy_read(phydev, MII_DP83867_PHYCTRL);