Commit d709f178 authored by Kohei Enju's avatar Kohei Enju Committed by Tony Nguyen
Browse files

igb: fix link test skipping when interface is admin down 



The igb driver incorrectly skips the link test when the network
interface is admin down (if_running == false), causing the test to
always report PASS regardless of the actual physical link state.

This behavior is inconsistent with other drivers (e.g. i40e, ice, ixgbe,
etc.) which correctly test the physical link state regardless of admin
state.
Remove the if_running check to ensure link test always reflects the
physical link state.

Fixes: 8d420a1b ("igb: correct link test not being run when link is down")
Signed-off-by: default avatarKohei Enju <enjuk@amazon.com>
Reviewed-by: default avatarPaul Menzel <pmenzel@molgen.mpg.de>
Tested-by: Rinitha S <sx.rinitha@intel.com> (A Contingent worker at Intel)
Signed-off-by: default avatarTony Nguyen <anthony.l.nguyen@intel.com>
parent 75871a52

drivers/net/ethernet/intel/igb/igb_ethtool.c

+1 −4
Original line number Diff line number Diff line
@@ -2081,11 +2081,8 @@ static void igb_diag_test(struct net_device *netdev, 
	} else {

		dev_info(&adapter->pdev->dev, "online testing starting\n");



		/* PHY is powered down when interface is down */

		if (if_running && igb_link_test(adapter, &data[TEST_LINK]))

		if (igb_link_test(adapter, &data[TEST_LINK]))

			eth_test->flags |= ETH_TEST_FL_FAILED;

		else

			data[TEST_LINK] = 0;



		/* Online tests aren't run; pass by default */

		data[TEST_REG] = 0;