Commit d7730c44 authored by Charles Keepax's avatar Charles Keepax Committed by Mark Brown
Browse files

ASoC: SDCA: Still process most of the jack detect if control is missing 



DAPM creates its controls very late in the card creation, so
there is no call into the driver after the controls are created. This
means the jack IRQs can't be guaranteed to be registered after the ALSA
controls are available. If a jack IRQ is received before the controls
are available, currently the driver does not update the Selected Mode as
it is required by the specification to do.

If the ALSA controls are not available update the Selected Mode directly
rather than going through the ALSA control. The ALSA control should pick
up the state once it is created.

Fixes: b9ab3b61 ("ASoC: SDCA: Add some initial IRQ handlers")
Signed-off-by: default avatarCharles Keepax <ckeepax@opensource.cirrus.com>
Link: https://patch.msgid.link/20260204125944.1134011-4-ckeepax@opensource.cirrus.com


Reviewed-by: default avatarPierre-Louis Bossart <pierre-louis.bossart@linux.dev>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 9fad74b7

sound/soc/sdca/sdca_jack.c

+28 −24
Original line number Diff line number Diff line
@@ -41,10 +41,11 @@ int sdca_jack_process(struct sdca_interrupt *interrupt) 
	struct jack_state *state = interrupt->priv;

	struct snd_kcontrol *kctl = state->kctl;

	struct snd_ctl_elem_value *ucontrol __free(kfree) = NULL;

	struct soc_enum *soc_enum;

	unsigned int reg, val;

	int ret;



	guard(rwsem_write)(rwsem);



	if (!kctl) {

		const char *name __free(kfree) = kasprintf(GFP_KERNEL, "%s %s",

							   interrupt->entity->label,
@@ -54,16 +55,12 @@ int sdca_jack_process(struct sdca_interrupt *interrupt) 
			return -ENOMEM;



		kctl = snd_soc_component_get_kcontrol(component, name);

		if (!kctl) {

		if (!kctl)

			dev_dbg(dev, "control not found: %s\n", name);

			return -ENOENT;

		}



		else

			state->kctl = kctl;

	}



	soc_enum = (struct soc_enum *)kctl->private_value;



	reg = SDW_SDCA_CTL(interrupt->function->desc->adr, interrupt->entity->id,

			   interrupt->control->sel, 0);
@@ -73,13 +70,12 @@ int sdca_jack_process(struct sdca_interrupt *interrupt) 
		return ret;

	}



	reg = SDW_SDCA_CTL(interrupt->function->desc->adr, interrupt->entity->id,

			   SDCA_CTL_GE_SELECTED_MODE, 0);



	switch (val) {

	case SDCA_DETECTED_MODE_DETECTION_IN_PROGRESS:

	case SDCA_DETECTED_MODE_JACK_UNKNOWN:

		reg = SDW_SDCA_CTL(interrupt->function->desc->adr,

				   interrupt->entity->id,

				   SDCA_CTL_GE_SELECTED_MODE, 0);



		/*

		 * Selected mode is not normally marked as volatile register

		 * (RW), but here force a read from the hardware. If the
@@ -100,21 +96,29 @@ int sdca_jack_process(struct sdca_interrupt *interrupt) 


	dev_dbg(dev, "%s: %#x\n", interrupt->name, val);



	if (kctl) {

		struct soc_enum *soc_enum = (struct soc_enum *)kctl->private_value;



		ucontrol = kzalloc(sizeof(*ucontrol), GFP_KERNEL);

		if (!ucontrol)

			return -ENOMEM;



		ucontrol->value.enumerated.item[0] = snd_soc_enum_val_to_item(soc_enum, val);



	down_write(rwsem);

		ret = kctl->put(kctl, ucontrol);

	up_write(rwsem);

		if (ret < 0) {

			dev_err(dev, "failed to update selected mode: %d\n", ret);

			return ret;

		}



		snd_ctl_notify(card->snd_card, SNDRV_CTL_EVENT_MASK_VALUE, &kctl->id);

	} else {

		ret = regmap_write(interrupt->function_regmap, reg, val);

		if (ret) {

			dev_err(dev, "failed to write selected mode: %d\n", ret);

			return ret;

		}

	}



	return sdca_jack_report(interrupt);

}