Commit d7840aaa authored by Wang Wensheng's avatar Wang Wensheng Committed by Thomas Gleixner
Browse files

tick: Use tick_check_replacement() instead of open coding it 



The function tick_check_replacement() is the combination of
tick_check_percpu() and tick_check_preferred(), but tick_check_new_device()
has the same logic open coded.

Use the helper to simplify the code.

[ tglx: Massage changelog ]

Signed-off-by: default avatarWang Wensheng <wangwensheng4@huawei.com>
Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/r/20210326022328.3266-1-wangwensheng4@huawei.com
parent 07ff4aed

kernel/time/tick-common.c

+1 −6
Original line number Diff line number Diff line
@@ -348,12 +348,7 @@ void tick_check_new_device(struct clock_event_device *newdev) 
	td = &per_cpu(tick_cpu_device, cpu);

	curdev = td->evtdev;



	/* cpu local device ? */

	if (!tick_check_percpu(curdev, newdev, cpu))

		goto out_bc;



	/* Preference decision */

	if (!tick_check_preferred(curdev, newdev))

	if (!tick_check_replacement(curdev, newdev))

		goto out_bc;



	if (!try_module_get(newdev->owner))