Commit d7eb1f17 authored by Petr Machata's avatar Petr Machata Committed by David S. Miller
Browse files

selftests: mlxsw: rtnetlink: Drop obsolete tests 



Support for enslaving ports to LAGs with uppers will be added in the
following patches. Selftests to make sure it actually does the right thing
are ready and will be sent as a follow-up.

Similarly, ordering of MACVLAN creation and RIF creation will be relaxed
and it will be permitted to create a MACVLAN first.

Thus these two tests are obsolete. Drop them.

Signed-off-by: default avatarPetr Machata <petrm@nvidia.com>
Reviewed-by: default avatarDanielle Ratson <danieller@nvidia.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent f2e2857b

tools/testing/selftests/drivers/net/mlxsw/rtnetlink.sh

+0 −31
Original line number Diff line number Diff line
@@ -16,7 +16,6 @@ ALL_TESTS=" 
	bridge_deletion_test

	bridge_vlan_flags_test

	vlan_1_test

	lag_bridge_upper_test

	duplicate_vlans_test

	vlan_rif_refcount_test

	subport_rif_refcount_test
@@ -211,33 +210,6 @@ vlan_1_test() 
	ip link del dev $swp1.1

}



lag_bridge_upper_test()

{

	# Test that ports cannot be enslaved to LAG devices that have uppers

	# and that failure is handled gracefully. See commit b3529af6bb0d

	# ("spectrum: Reference count VLAN entries") for more details

	RET=0



	ip link add name bond1 type bond mode 802.3ad



	ip link add name br0 type bridge vlan_filtering 1

	ip link set dev bond1 master br0



	ip link set dev $swp1 down

	ip link set dev $swp1 master bond1 &> /dev/null

	check_fail $? "managed to enslave port to lag when should not"



	# This might generate a trace, if we did not handle the failure

	# correctly

	ip -6 address add 2001:db8:1::1/64 dev $swp1

	ip -6 address del 2001:db8:1::1/64 dev $swp1



	log_test "lag with bridge upper"



	ip link del dev br0

	ip link del dev bond1

}



duplicate_vlans_test()

{

	# Test that on a given port a VLAN is only used once. Either as VLAN
@@ -510,9 +482,6 @@ vlan_interface_uppers_test() 
	ip link set dev $swp1 master br0



	ip link add link br0 name br0.10 type vlan id 10

	ip link add link br0.10 name macvlan0 \

		type macvlan mode private &> /dev/null

	check_fail $? "managed to create a macvlan when should not"



	ip -6 address add 2001:db8:1::1/64 dev br0.10

	ip link add link br0.10 name macvlan0 type macvlan mode private