Commit d7ee9623 authored by Wander Lairson Costa's avatar Wander Lairson Costa Committed by Gabriele Monaco
Browse files

rv/rvgen: make monitor arguments required in rvgen 



Add required=True to the monitor subcommand arguments for class, spec,
and monitor_type in rvgen. These arguments are essential for monitor
generation and attempting to run without them would cause AttributeError
exceptions later in the code when the script tries to access them.

Making these arguments explicitly required provides clearer error
messages to users at parse time rather than cryptic exceptions during
execution. This improves the user experience by catching missing
arguments early with helpful usage information.

Signed-off-by: default avatarWander Lairson Costa <wander@redhat.com>
Reviewed-by: default avatarGabriele Monaco <gmonaco@redhat.com>
Reviewed-by: default avatarNam Cao <namcao@linutronix.de>
Link: https://lore.kernel.org/r/20260223162407.147003-15-wander@redhat.com


Signed-off-by: default avatarGabriele Monaco <gmonaco@redhat.com>
parent 1b615bb0

tools/verification/rvgen/__main__.py

+4 −3
Original line number Diff line number Diff line
@@ -29,10 +29,11 @@ if __name__ == '__main__': 
    monitor_parser.add_argument('-n', "--model_name", dest="model_name")

    monitor_parser.add_argument("-p", "--parent", dest="parent",

                                required=False, help="Create a monitor nested to parent")

    monitor_parser.add_argument('-c', "--class", dest="monitor_class",

    monitor_parser.add_argument('-c', "--class", dest="monitor_class", required=True,

                                help="Monitor class, either \"da\", \"ha\" or \"ltl\"")

    monitor_parser.add_argument('-s', "--spec", dest="spec", help="Monitor specification file")

    monitor_parser.add_argument('-t', "--monitor_type", dest="monitor_type",

    monitor_parser.add_argument('-s', "--spec", dest="spec", required=True,

                                help="Monitor specification file")

    monitor_parser.add_argument('-t', "--monitor_type", dest="monitor_type", required=True,

                                help=f"Available options: {', '.join(Monitor.monitor_types.keys())}")



    container_parser = subparsers.add_parser("container")