Commit d81603b3 authored by Yury Norov's avatar Yury Norov
Browse files

objpool: rework objpool_pop() 



The function has to track number of iterations to prevent an infinite
loop. for_each_cpu_wrap() macro takes care of it, which simplifies user
code.

Signed-off-by: default avatarYury Norov <yury.norov@gmail.com>
parent 9ffa4b35

include/linux/objpool.h

+3 −4
Original line number Diff line number Diff line
@@ -170,17 +170,16 @@ static inline void *objpool_pop(struct objpool_head *pool) 
{

	void *obj = NULL;

	unsigned long flags;

	int i, cpu;

	int start, cpu;



	/* disable local irq to avoid preemption & interruption */

	raw_local_irq_save(flags);



	cpu = raw_smp_processor_id();

	for (i = 0; i < pool->nr_possible_cpus; i++) {

	start = raw_smp_processor_id();

	for_each_possible_cpu_wrap(cpu, start) {

		obj = __objpool_try_get_slot(pool, cpu);

		if (obj)

			break;

		cpu = cpumask_next_wrap(cpu, cpu_possible_mask, -1, 1);

	}

	raw_local_irq_restore(flags);