Commit d8214d0f authored by Michael Chan's avatar Michael Chan Committed by Jakub Kicinski
Browse files

bnxt_en: Fix RCU locking for ntuple filters in bnxt_rx_flow_steer() 



Similar to the previous patch, RCU locking was released too early
in bnxt_rx_flow_steer().  Fix it to unlock after reading fltr->base.sw_id
to guarantee that fltr won't be freed while we are still reading it.

Fixes: cb5bdd29 ("bnxt_en: Add bnxt_lookup_ntp_filter_from_idx() function")
Reported-by: default avatarSimon Horman <horms@kernel.org>
Link: https://lore.kernel.org/netdev/20231225165653.GH5962@kernel.org/


Signed-off-by: default avatarMichael Chan <michael.chan@broadcom.com>
Reviewed-by: default avatarSimon Horman <horms@kernel.org>
Link: https://lore.kernel.org/r/20240105235439.28282-4-michael.chan@broadcom.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent fd776979

drivers/net/ethernet/broadcom/bnxt/bnxt.c

+1 −1
Original line number Diff line number Diff line
@@ -14020,8 +14020,8 @@ static int bnxt_rx_flow_steer(struct net_device *dev, const struct sk_buff *skb, 
	rcu_read_lock();

	fltr = bnxt_lookup_ntp_filter_from_idx(bp, new_fltr, idx);

	if (fltr) {

		rcu_read_unlock();

		rc = fltr->base.sw_id;

		rcu_read_unlock();

		goto err_free;

	}

	rcu_read_unlock();