Commit d82e86c1 authored by Sergey Shtylyov's avatar Sergey Shtylyov Committed by Trond Myklebust
Browse files

nfs: direct: drop useless initializer in nfs_direct_write_completion() 



In nfs_direct_write_completion(), the local variable req isn't used outside
the *while* loop and is assigned to right at the start of that loop's body,
so its initializer appears useless -- drop it; then move the declaration to
the loop body (which happens to have a pointless empty line anyway)...

Found by Linux Verification Center (linuxtesting.org) with the Svace static
analysis tool.

Signed-off-by: default avatarSergey Shtylyov <s.shtylyov@omp.ru>
Reviewed-by: default avatarBenjamin Coddington <bcodding@redhat.com>
Link: https://lore.kernel.org/r/416219f5-7983-484b-b5a7-5fb7da9561f7@omp.ru


Signed-off-by: default avatarTrond Myklebust <trond.myklebust@hammerspace.com>
parent d5fb22a7

fs/nfs/direct.c

+1 −1
Original line number Diff line number Diff line
@@ -757,7 +757,6 @@ static void nfs_direct_write_completion(struct nfs_pgio_header *hdr) 
{

	struct nfs_direct_req *dreq = hdr->dreq;

	struct nfs_commit_info cinfo;

	struct nfs_page *req = nfs_list_entry(hdr->pages.next);

	struct inode *inode = dreq->inode;

	int flags = NFS_ODIRECT_DONE;
@@ -786,6 +785,7 @@ static void nfs_direct_write_completion(struct nfs_pgio_header *hdr) 
	spin_unlock(&inode->i_lock);



	while (!list_empty(&hdr->pages)) {

		struct nfs_page *req;



		req = nfs_list_entry(hdr->pages.next);

		nfs_list_remove_request(req);