Commit d83b40ef authored Sep 24, 2023 by Laurent Pinchart Committed by Hans Verkuil Oct 07, 2023

media: i2c: imx219: Remove unneeded goto



Simplify the imx219_set_stream() by removing an unneeded goto statement,
and its corresponding error label. The natural flow of the function is
correct.

While at it, drop a useless comment.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>

parent d03dfb7d

drivers/media/i2c/imx219.c

+2 −10

Original line number	Diff line number	Diff line
		@@ -760,19 +760,11 @@ static int imx219_set_stream(struct v4l2_subdev *sd, int enable)

		state = v4l2_subdev_lock_and_get_active_state(sd);

		if (enable) {
		/*
		* Apply default & customized values
		* and then start streaming.
		*/
		if (enable)
		ret = imx219_start_streaming(imx219, state);
		if (ret)
		goto unlock;
		} else {
		else
		imx219_stop_streaming(imx219);
		}

		unlock:
		v4l2_subdev_unlock_state(state);
		return ret;
		}