Commit d83c45ae authored by Daniel Schaefer's avatar Daniel Schaefer Committed by Tzung-Bi Shih
Browse files

platform/chrome: cros_ec_lpc: Match on Framework ACPI device 



Load the cros_ec_lpc driver based on a Framework FRMWC004 ACPI device,
which mirrors GOOG0004, but also applies npcx quirks for Framework
systems.

Matching on ACPI will let us avoid having to change the SMBIOS match
rules again and again.

Cc: Tzung-Bi Shih <tzungbi@kernel.org>
Cc: linux@frame.work
Cc: Dustin L. Howett <dustin@howett.net>
Signed-off-by: default avatarDaniel Schaefer <dhs@frame.work>
Link: https://lore.kernel.org/r/20250128181329.8070-1-dhs@frame.work


Signed-off-by: default avatarTzung-Bi Shih <tzungbi@kernel.org>
parent 57b38c3c

drivers/platform/chrome/cros_ec_lpc.c

+14 −8
Original line number Diff line number Diff line
@@ -30,6 +30,7 @@ 


#define DRV_NAME "cros_ec_lpcs"

#define ACPI_DRV_NAME "GOOG0004"

#define FRMW_ACPI_DRV_NAME "FRMWC004"



/* True if ACPI device is present */

static bool cros_ec_lpc_acpi_device_found;
@@ -514,7 +515,7 @@ static int cros_ec_lpc_probe(struct platform_device *pdev) 
	acpi_status status;

	struct cros_ec_device *ec_dev;

	struct cros_ec_lpc *ec_lpc;

	struct lpc_driver_data *driver_data;

	const struct lpc_driver_data *driver_data;

	u8 buf[2] = {};

	int irq, ret;

	u32 quirks;
@@ -526,6 +527,9 @@ static int cros_ec_lpc_probe(struct platform_device *pdev) 
	ec_lpc->mmio_memory_base = EC_LPC_ADDR_MEMMAP;



	driver_data = platform_get_drvdata(pdev);

	if (!driver_data)

		driver_data = acpi_device_get_match_data(dev);



	if (driver_data) {

		quirks = driver_data->quirks;
@@ -696,12 +700,6 @@ static void cros_ec_lpc_remove(struct platform_device *pdev) 
	cros_ec_unregister(ec_dev);

}



static const struct acpi_device_id cros_ec_lpc_acpi_device_ids[] = {

	{ ACPI_DRV_NAME, 0 },

	{ }

};

MODULE_DEVICE_TABLE(acpi, cros_ec_lpc_acpi_device_ids);



static const struct lpc_driver_data framework_laptop_npcx_lpc_driver_data __initconst = {

	.quirks = CROS_EC_LPC_QUIRK_REMAP_MEMORY,

	.quirk_mmio_memory_base = 0xE00,
@@ -713,6 +711,13 @@ static const struct lpc_driver_data framework_laptop_mec_lpc_driver_data __initc 
	.quirk_aml_mutex_name = "ECMT",

};



static const struct acpi_device_id cros_ec_lpc_acpi_device_ids[] = {

	{ ACPI_DRV_NAME, 0 },

	{ FRMW_ACPI_DRV_NAME, (kernel_ulong_t)&framework_laptop_npcx_lpc_driver_data },

	{ }

};

MODULE_DEVICE_TABLE(acpi, cros_ec_lpc_acpi_device_ids);



static const struct dmi_system_id cros_ec_lpc_dmi_table[] __initconst = {

	{

		/*
@@ -866,7 +871,8 @@ static int __init cros_ec_lpc_init(void) 
	int ret;

	const struct dmi_system_id *dmi_match;



	cros_ec_lpc_acpi_device_found = !!cros_ec_lpc_get_device(ACPI_DRV_NAME);

	cros_ec_lpc_acpi_device_found = !!cros_ec_lpc_get_device(ACPI_DRV_NAME) ||

		!!cros_ec_lpc_get_device(FRMW_ACPI_DRV_NAME);



	dmi_match = dmi_first_match(cros_ec_lpc_dmi_table);