Commit d847188b authored by Wander Lairson Costa's avatar Wander Lairson Costa Committed by Tomas Glozar
Browse files

rtla: Handle pthread_create() failure properly 



Add proper error handling when pthread_create() fails to create the
timerlat user-space dispatcher thread. Previously, the code only logged
an error message but continued execution, which could lead to undefined
behavior when the tool later expects the thread to be running.

When pthread_create() returns an error, the function now jumps to the
out_trace error path to properly clean up resources and exit. This
ensures consistent error handling and prevents the tool from running
in an invalid state without the required user-space thread.

Signed-off-by: default avatarWander Lairson Costa <wander@redhat.com>
Link: https://lore.kernel.org/r/20260309195040.1019085-10-wander@redhat.com


Signed-off-by: default avatarTomas Glozar <tglozar@redhat.com>
parent d6515424

tools/tracing/rtla/src/common.c

+3 −1
Original line number Diff line number Diff line
@@ -336,8 +336,10 @@ int run_tool(struct tool_ops *ops, int argc, char *argv[]) 
		params->user.cgroup_name = params->cgroup_name;



		retval = pthread_create(&user_thread, NULL, timerlat_u_dispatcher, &params->user);

		if (retval)

		if (retval) {

			err_msg("Error creating timerlat user-space threads\n");

			goto out_trace;

		}

	}



	retval = ops->enable(tool);