Commit d85080df authored by Dr. David Alan Gilbert's avatar Dr. David Alan Gilbert Committed by Leon Romanovsky
Browse files

RDMA/rxe: Remove unused rxe_run_task 



rxe_run_task() has been unused since 2024's
commit 23bc06af ("RDMA/rxe: Don't call direct between tasks")

Remove it.

Signed-off-by: default avatarDr. David Alan Gilbert <linux@treblig.org>
Link: https://patch.msgid.link/20250419132725.199785-1-linux@treblig.org


Signed-off-by: default avatarLeon Romanovsky <leon@kernel.org>
parent 1c7eec4d

drivers/infiniband/sw/rxe/rxe_task.c

+11 −29
Original line number Diff line number Diff line
@@ -85,17 +85,17 @@ static bool is_done(struct rxe_task *task) 


/* do_task is a wrapper for the three tasks (requester,

 * completer, responder) and calls them in a loop until

 * they return a non-zero value. It is called either

 * directly by rxe_run_task or indirectly if rxe_sched_task

 * schedules the task. They must call __reserve_if_idle to

 * move the task to busy before calling or scheduling.

 * The task can also be moved to drained or invalid

 * by calls to rxe_cleanup_task or rxe_disable_task.

 * In that case tasks which get here are not executed but

 * just flushed. The tasks are designed to look to see if

 * there is work to do and then do part of it before returning

 * here with a return value of zero until all the work

 * has been consumed then it returns a non-zero value.

 * they return a non-zero value. It is called indirectly

 * when rxe_sched_task schedules the task. They must

 * call __reserve_if_idle to move the task to busy before

 * calling or scheduling. The task can also be moved to

 * drained or invalid by calls to rxe_cleanup_task or

 * rxe_disable_task. In that case tasks which get here

 * are not executed but just flushed. The tasks are

 * designed to look to see if there is work to do and

 * then do part of it before returning here with a return

 * value of zero until all the work has been consumed then

 * it returns a non-zero value.

 * The number of times the task can be run is limited by

 * max iterations so one task cannot hold the cpu forever.

 * If the limit is hit and work remains the task is rescheduled.
@@ -234,24 +234,6 @@ void rxe_cleanup_task(struct rxe_task *task) 
	spin_unlock_irqrestore(&task->lock, flags);

}



/* run the task inline if it is currently idle

 * cannot call do_task holding the lock

 */

void rxe_run_task(struct rxe_task *task)

{

	unsigned long flags;

	bool run;



	WARN_ON(rxe_read(task->qp) <= 0);



	spin_lock_irqsave(&task->lock, flags);

	run = __reserve_if_idle(task);

	spin_unlock_irqrestore(&task->lock, flags);



	if (run)

		do_task(task);

}



/* schedule the task to run later as a work queue entry.

 * the queue_work call can be called holding

 * the lock.

drivers/infiniband/sw/rxe/rxe_task.h

+0 −2
Original line number Diff line number Diff line
@@ -47,8 +47,6 @@ int rxe_init_task(struct rxe_task *task, struct rxe_qp *qp, 
/* cleanup task */

void rxe_cleanup_task(struct rxe_task *task);



void rxe_run_task(struct rxe_task *task);



void rxe_sched_task(struct rxe_task *task);



/* keep a task from scheduling */