Commit d891317f authored by Li RongQing's avatar Li RongQing Committed by Jakub Kicinski
Browse files

virtio_net: Remove u64_stats_update_begin()/end() for stats fetch 



This place is fetching the stats, u64_stats_update_begin()/end()
should not be used, and the fetcher of stats is in the same context
as the updater of the stats, so don't need any protection

Suggested-by: default avatarJakub Kicinski <kuba@kernel.org>
Acked-by: default avatarMichael S. Tsirkin <mst@redhat.com>
Signed-off-by: default avatarLi RongQing <lirongqing@baidu.com>
Link: https://lore.kernel.org/20240621094552.53469-1-lirongqing@baidu.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent c4532232

drivers/net/virtio_net.c

+3 −2
Original line number Diff line number Diff line
@@ -2382,12 +2382,13 @@ static void virtnet_rx_dim_update(struct virtnet_info *vi, struct receive_queue 
	if (!rq->packets_in_napi)

		return;



	u64_stats_update_begin(&rq->stats.syncp);

	/* Don't need protection when fetching stats, since fetcher and

	 * updater of the stats are in same context

	 */

	dim_update_sample(rq->calls,

			  u64_stats_read(&rq->stats.packets),

			  u64_stats_read(&rq->stats.bytes),

			  &cur_sample);

	u64_stats_update_end(&rq->stats.syncp);



	net_dim(&rq->dim, cur_sample);

	rq->packets_in_napi = 0;