Commit d8960dfb authored by Hui Wang's avatar Hui Wang Committed by Lee Jones
Browse files

leds: pwm: Clear the led structure before parsing each child node 



I defined 2 leds in the device tree, in the 1st led node, the
max-brightness is set to 248, while in the 2nd led node, I
mis-spelled the max-brightness to max-brighttness, but the driver
is still able to get the max-brightness 248 for the 2nd node,  that
is because the led structure is not cleared before parsing each child
node.

	pwmleds {
		compatible = "pwm-leds";

		pwm-green {
			...
			max-brightness = <248>;
		};

		pwm-red {
		        ...
			max-brighttness = <128>;
		};

Signed-off-by: default avatarHui Wang <hui.wang@canonical.com>
Signed-off-by: default avatarLee Jones <lee@kernel.org>
Link: https://lore.kernel.org/r/20221220073335.393489-1-hui.wang@canonical.com
parent abc3100f

drivers/leds/leds-pwm.c

+2 −2
Original line number Diff line number Diff line
@@ -138,9 +138,9 @@ static int led_pwm_create_fwnode(struct device *dev, struct led_pwm_priv *priv) 
	struct led_pwm led;

	int ret;



	device_for_each_child_node(dev, fwnode) {

		memset(&led, 0, sizeof(led));



	device_for_each_child_node(dev, fwnode) {

		ret = fwnode_property_read_string(fwnode, "label", &led.name);

		if (ret && is_of_node(fwnode))

			led.name = to_of_node(fwnode)->name;