Unverified Commit d89aad92 authored by Dimitrios Katsaros's avatar Dimitrios Katsaros Committed by Mark Brown
Browse files

ASoC: tlv320adcx140: Propagate error codes during probe 



When scanning for the reset pin, we could get an -EPROBE_DEFER.
The driver would assume that no reset pin had been defined,
which would mean that the chip would never be powered.

Now we both respect any error we get from devm_gpiod_get_optional.
We also now properly report the missing GPIO definition when
'gpio_reset' is NULL.

Signed-off-by: default avatarDimitrios Katsaros <patcherwork@gmail.com>
Signed-off-by: default avatarSascha Hauer <s.hauer@pengutronix.de>
Link: https://patch.msgid.link/20260113-sound-soc-codecs-tvl320adcx140-v4-3-8f7ecec525c8@pengutronix.de


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent be7664c8

sound/soc/codecs/tlv320adcx140.c

+3 −0
Original line number Diff line number Diff line
@@ -1154,6 +1154,9 @@ static int adcx140_i2c_probe(struct i2c_client *i2c) 
	adcx140->gpio_reset = devm_gpiod_get_optional(adcx140->dev,

						      "reset", GPIOD_OUT_LOW);

	if (IS_ERR(adcx140->gpio_reset))

		return dev_err_probe(&i2c->dev, PTR_ERR(adcx140->gpio_reset),

				     "Failed to get Reset GPIO\n");

	if (!adcx140->gpio_reset)

		dev_info(&i2c->dev, "Reset GPIO not defined\n");



	adcx140->supply_areg = devm_regulator_get_optional(adcx140->dev,