Commit d8a26a18 authored by Andy Shevchenko's avatar Andy Shevchenko
Browse files

gpiolib: acpi: Check for errors first in acpi_find_gpio() 



It's better to parse the code when the usual pattern is being used,
i.e. checking for error condition first.

There is no functional or code generation change (tested in LLVM).

Acked-by: default avatarMika Westerberg <mika.westerberg@linux.intel.com>
Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
parent 7057fc74

drivers/gpio/gpiolib-acpi.c

+3 −2
Original line number Diff line number Diff line
@@ -973,10 +973,11 @@ struct gpio_desc *acpi_find_gpio(struct fwnode_handle *fwnode, 
		else

			desc = acpi_get_gpiod_from_data(fwnode,

						        propname, idx, &info);

		if (!IS_ERR(desc))

			break;

		if (PTR_ERR(desc) == -EPROBE_DEFER)

			return ERR_CAST(desc);



		if (!IS_ERR(desc))

			break;

	}



	/* Then from plain _CRS GPIOs */