Commit d8d7aa22 authored by Benjamin Tissoires's avatar Benjamin Tissoires
Browse files

selftests/hid: tablets: do not set invert when the eraser is used 

Turns out that the chart from Microsoft is not exactly what I got here:
when the rubber is used, and is touching the surface, invert can (should)
be set to 0...

[0] https://learn.microsoft.com/en-us/windows-hardware/design/component-guidelines/windows-pen-states



Reviewed-by: default avatarPeter Hutterer <peter.hutterer@who-t.net>
Acked-by: default avatarJiri Kosina <jkosina@suse.com>
Link: https://lore.kernel.org/r/20231206-wip-selftests-v2-7-c0350c2f5986@kernel.org


Signed-off-by: default avatarBenjamin Tissoires <bentiss@kernel.org>
parent 881ccc36

tools/testing/selftests/hid/tests/test_tablet.py

+1 −1
Original line number Diff line number Diff line
@@ -382,7 +382,7 @@ class PenDigitizer(base.UHIDTestDevice): 
        elif state == PenState.PEN_IS_ERASING:

            pen.tipswitch = False

            pen.inrange = True

            pen.invert = True

            pen.invert = False

            pen.eraser = True



        pen.current_state = state