Commit d8eddb62 authored by Domen Puncer's avatar Domen Puncer Committed by Linus Torvalds
Browse files

[PATCH] char/ds1620: use msleep() instead of schedule_timeout() 



Not sure why any driver needs to sleep for *two* ticks, so let's fix it.

Use msleep() instead of schedule_timeout() to guarantee the task delays as
expected.  Signals are never checked for by the callers or in the function
itself, so use TASK_UNINTERRUPTIBLE instead of TASK_INTERRUPTIBLE.  The
delay is presumed to have been written when HZ==100, and thus has been
multiplied by 10 to pass to msleep().

Signed-off-by: default avatarNishanth Aravamudan <nacc@us.ibm.com>
Signed-off-by: default avatarDomen Puncer <domen@coderock.org>
Acked-by: default avatarRussell King <rmk@arm.linux.org.uk>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent d2a457cf

drivers/char/ds1620.c

+1 −2
Original line number Diff line number Diff line
@@ -163,8 +163,7 @@ static void ds1620_out(int cmd, int bits, int value) 
	netwinder_ds1620_reset();

	netwinder_unlock(&flags);



	set_current_state(TASK_INTERRUPTIBLE);

	schedule_timeout(2);

	msleep(20);

}



static unsigned int ds1620_in(int cmd, int bits)