Unverified Commit d90ad28e authored by Andrey Albershteyn's avatar Andrey Albershteyn Committed by Christian Brauner
Browse files

fs: return EOPNOTSUPP from file_setattr/file_getattr syscalls 



These syscalls call to vfs_fileattr_get/set functions which return
ENOIOCTLCMD if filesystem doesn't support setting file attribute on an
inode. For syscalls EOPNOTSUPP would be more appropriate return error.

Signed-off-by: default avatarAndrey Albershteyn <aalbersh@kernel.org>
Reviewed-by: default avatarJan Kara <jack@suse.cz>
Reviewed-by: default avatarArnd Bergmann <arnd@arndb.de>
Signed-off-by: default avatarChristian Brauner <brauner@kernel.org>
parent 4dd5b5ac

fs/file_attr.c

+4 −0
Original line number Diff line number Diff line
@@ -416,6 +416,8 @@ SYSCALL_DEFINE5(file_getattr, int, dfd, const char __user *, filename, 
	}



	error = vfs_fileattr_get(filepath.dentry, &fa);

	if (error == -ENOIOCTLCMD || error == -ENOTTY)

		error = -EOPNOTSUPP;

	if (error)

		return error;
@@ -483,6 +485,8 @@ SYSCALL_DEFINE5(file_setattr, int, dfd, const char __user *, filename, 
	if (!error) {

		error = vfs_fileattr_set(mnt_idmap(filepath.mnt),

					 filepath.dentry, &fa);

		if (error == -ENOIOCTLCMD || error == -ENOTTY)

			error = -EOPNOTSUPP;

		mnt_drop_write(filepath.mnt);

	}