Unverified Commit d93cca2f authored by David McKay's avatar David McKay Committed by Arnd Bergmann
Browse files

asm-generic: Fix 32 bit __generic_cmpxchg_local 



Commit 656e9007 ("asm-generic: avoid __generic_cmpxchg_local
warnings") introduced a typo that means the code is incorrect for 32 bit
values. It will work fine for postive numbers, but will fail for
negative numbers on a system where longs are 64 bit.

Fixes: 656e9007 ("asm-generic: avoid __generic_cmpxchg_local warnings")
Signed-off-by: default avatarDavid McKay <david.mckay@codasip.com>
Signed-off-by: default avatarStuart Menefy <stuart.menefy@codasip.com>
Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
parent d6e81532

include/asm-generic/cmpxchg-local.h

+1 −1
Original line number Diff line number Diff line
@@ -34,7 +34,7 @@ static inline unsigned long __generic_cmpxchg_local(volatile void *ptr, 
			*(u16 *)ptr = (new & 0xffffu);

		break;

	case 4: prev = *(u32 *)ptr;

		if (prev == (old & 0xffffffffffu))

		if (prev == (old & 0xffffffffu))

			*(u32 *)ptr = (new & 0xffffffffu);

		break;

	case 8: prev = *(u64 *)ptr;