Commit d94ae641 authored by Amit Cohen's avatar Amit Cohen Committed by Jakub Kicinski
Browse files

mlxsw: pci: Use napi_consume_skb() to free SKB as part of Tx completion 



Currently, as part of Tx completion, the driver calls dev_kfree_skb_any()
to free the SKB. For this flow, the correct function is napi_consume_skb().
This function and dev_consume_skb_any() were added to be used for consumed
SKBs, which were not dropped, so the skb:kfree_skb tracepoint is not
triggered, and we can get better diagnostics about dropped packets.

Signed-off-by: default avatarAmit Cohen <amcohen@nvidia.com>
Reviewed-by: default avatarIdo Schimmel <idosch@nvidia.com>
Signed-off-by: default avatarPetr Machata <petrm@nvidia.com>
Reviewed-by: default avatarJiri Pirko <jiri@nvidia.com>
Link: https://lore.kernel.org/r/a9f9f3dc884c0d1be4bd4c9d72030c88c7ac004f.1718709196.git.petrm@nvidia.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent e8441b1f

drivers/net/ethernet/mellanox/mlxsw/pci.c

+3 −3
Original line number Diff line number Diff line
@@ -541,7 +541,7 @@ static void mlxsw_pci_cqe_sdq_handle(struct mlxsw_pci *mlxsw_pci, 
				     struct mlxsw_pci_queue *q,

				     u16 consumer_counter_limit,

				     enum mlxsw_pci_cqe_v cqe_v,

				     char *cqe)

				     char *cqe, int budget)

{

	struct pci_dev *pdev = mlxsw_pci->pdev;

	struct mlxsw_pci_queue_elem_info *elem_info;
@@ -567,7 +567,7 @@ static void mlxsw_pci_cqe_sdq_handle(struct mlxsw_pci *mlxsw_pci, 
	}



	if (skb)

		dev_kfree_skb_any(skb);

		napi_consume_skb(skb, budget);

	elem_info->sdq.skb = NULL;



	if (q->consumer_counter++ != consumer_counter_limit)
@@ -819,7 +819,7 @@ static int mlxsw_pci_napi_poll_cq_tx(struct napi_struct *napi, int budget) 
		mlxsw_pci_queue_doorbell_consumer_ring(mlxsw_pci, q);



		mlxsw_pci_cqe_sdq_handle(mlxsw_pci, sdq,

					 wqe_counter, q->u.cq.v, ncqe);

					 wqe_counter, q->u.cq.v, ncqe, budget);



		work_done++;

	}