Commit d998ddc8 authored by Aleksandr Mishin's avatar Aleksandr Mishin Committed by Daniel Lezcano
Browse files

thermal/drivers/tsens: Fix null pointer dereference 



compute_intercept_slope() is called from calibrate_8960() (in tsens-8960.c)
as compute_intercept_slope(priv, p1, NULL, ONE_PT_CALIB) which lead to null
pointer dereference (if DEBUG or DYNAMIC_DEBUG set).
Fix this bug by adding null pointer check.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: dfc1193d ("thermal/drivers/tsens: Replace custom 8960 apis with generic apis")
Signed-off-by: default avatarAleksandr Mishin <amishin@t-argos.ru>
Reviewed-by: default avatarKonrad Dybcio <konrad.dybcio@linaro.org>
Signed-off-by: default avatarDaniel Lezcano <daniel.lezcano@linaro.org>
Link: https://lore.kernel.org/r/20240411114021.12203-1-amishin@t-argos.ru
parent 7954c92e

drivers/thermal/qcom/tsens.c

+1 −1
Original line number Diff line number Diff line
@@ -265,7 +265,7 @@ void compute_intercept_slope(struct tsens_priv *priv, u32 *p1, 
	for (i = 0; i < priv->num_sensors; i++) {

		dev_dbg(priv->dev,

			"%s: sensor%d - data_point1:%#x data_point2:%#x\n",

			__func__, i, p1[i], p2[i]);

			__func__, i, p1[i], p2 ? p2[i] : 0);



		if (!priv->sensor[i].slope)

			priv->sensor[i].slope = SLOPE_DEFAULT;