Unverified Commit d9b3a3c7 authored by Andreas Gruenbacher's avatar Andreas Gruenbacher Committed by Christian Brauner
Browse files

gfs2: use lockref_init for gl_lockref 



Move the initialization of gl_lockref from gfs2_init_glock_once() to
gfs2_glock_get().  This allows to use lockref_init() there.

Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarAndreas Gruenbacher <agruenba@redhat.com>
Link: https://lore.kernel.org/r/20250130135624.1899988-2-agruenba@redhat.com


Signed-off-by: default avatarChristian Brauner <brauner@kernel.org>
parent e52e97f0

fs/gfs2/glock.c

+1 −1
Original line number Diff line number Diff line
@@ -1201,8 +1201,8 @@ int gfs2_glock_get(struct gfs2_sbd *sdp, u64 number, 
	if (glops->go_instantiate)

		gl->gl_flags |= BIT(GLF_INSTANTIATE_NEEDED);

	gl->gl_name = name;

	lockref_init(&gl->gl_lockref, 1);

	lockdep_set_subclass(&gl->gl_lockref.lock, glops->go_subclass);

	gl->gl_lockref.count = 1;

	gl->gl_state = LM_ST_UNLOCKED;

	gl->gl_target = LM_ST_UNLOCKED;

	gl->gl_demote_state = LM_ST_EXCLUSIVE;

fs/gfs2/main.c

+0 −1
Original line number Diff line number Diff line
@@ -51,7 +51,6 @@ static void gfs2_init_glock_once(void *foo) 
{

	struct gfs2_glock *gl = foo;



	spin_lock_init(&gl->gl_lockref.lock);

	INIT_LIST_HEAD(&gl->gl_holders);

	INIT_LIST_HEAD(&gl->gl_lru);

	INIT_LIST_HEAD(&gl->gl_ail_list);