Commit d9cfb519 authored by Vinicius Costa Gomes's avatar Vinicius Costa Gomes Committed by Vinod Koul
Browse files

dmaengine: idxd: Fix memory leak when a wq is reset 



idxd_wq_disable_cleanup() which is called from the reset path for a
workqueue, sets the wq type to NONE, which for other parts of the
driver mean that the wq is empty (all its resources were released).

Only set the wq type to NONE after its resources are released.

Fixes: da32b28c ("dmaengine: idxd: cleanup workqueue config after disabling")
Reviewed-by: default avatarDave Jiang <dave.jiang@intel.com>
Signed-off-by: default avatarVinicius Costa Gomes <vinicius.gomes@intel.com>
Link: https://patch.msgid.link/20260121-idxd-fix-flr-on-kernel-queues-v3-v3-8-7ed70658a9d1@intel.com


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent 3d33de35

drivers/dma/idxd/device.c

+1 −2
Original line number Diff line number Diff line
@@ -175,6 +175,7 @@ void idxd_wq_free_resources(struct idxd_wq *wq) 
	free_descs(wq);

	dma_free_coherent(dev, wq->compls_size, wq->compls, wq->compls_addr);

	sbitmap_queue_free(&wq->sbq);

	wq->type = IDXD_WQT_NONE;

}

EXPORT_SYMBOL_NS_GPL(idxd_wq_free_resources, "IDXD");
@@ -382,7 +383,6 @@ static void idxd_wq_disable_cleanup(struct idxd_wq *wq) 
	lockdep_assert_held(&wq->wq_lock);

	wq->state = IDXD_WQ_DISABLED;

	memset(wq->wqcfg, 0, idxd->wqcfg_size);

	wq->type = IDXD_WQT_NONE;

	wq->threshold = 0;

	wq->priority = 0;

	wq->enqcmds_retries = IDXD_ENQCMDS_RETRIES;
@@ -1558,7 +1558,6 @@ void idxd_drv_disable_wq(struct idxd_wq *wq) 
	idxd_wq_reset(wq);

	idxd_wq_free_resources(wq);

	percpu_ref_exit(&wq->wq_active);

	wq->type = IDXD_WQT_NONE;

	wq->client_count = 0;

}

EXPORT_SYMBOL_NS_GPL(idxd_drv_disable_wq, "IDXD");