Commit da107152 authored by Christophe Leroy (CS GROUP)'s avatar Christophe Leroy (CS GROUP) Committed by Madhavan Srinivasan
Browse files

powerpc/8xx: Fix interrupt mask in cpm1_gpiochip_add16() 



Allthough fsl,cpm1-gpio-irq-mask always contains a 16 bits value,
it is a standard u32 OF property as documented in
Documentation/devicetree/bindings/soc/fsl/cpm_qe/gpio.txt

The driver erroneously uses of_property_read_u16() leading to a
mask which is always 0.

Fix it by using of_property_read_u32() instead.

Fixes: 726bd223 ("powerpc/8xx: Adding support of IRQ in MPC8xx GPIO")
Signed-off-by: default avatarChristophe Leroy (CS GROUP) <chleroy@kernel.org>
Signed-off-by: default avatarMadhavan Srinivasan <maddy@linux.ibm.com>
Link: https://patch.msgid.link/bb0b6d6c4543238c38d5d29a776d0674a8c0c180.1776752750.git.chleroy@kernel.org
parent 38e989d5

arch/powerpc/platforms/8xx/cpm1.c

+2 −2
Original line number Diff line number Diff line
@@ -477,7 +477,7 @@ int cpm1_gpiochip_add16(struct device *dev) 
	struct device_node *np = dev->of_node;

	struct cpm1_gpio16_chip *cpm1_gc;

	struct gpio_chip *gc;

	u16 mask;

	u32 mask;



	cpm1_gc = devm_kzalloc(dev, sizeof(*cpm1_gc), GFP_KERNEL);

	if (!cpm1_gc)
@@ -485,7 +485,7 @@ int cpm1_gpiochip_add16(struct device *dev) 


	spin_lock_init(&cpm1_gc->lock);



	if (!of_property_read_u16(np, "fsl,cpm1-gpio-irq-mask", &mask)) {

	if (!of_property_read_u32(np, "fsl,cpm1-gpio-irq-mask", &mask)) {

		int i, j;



		for (i = 0, j = 0; i < 16; i++)