Commit da4d8c83 authored by Davidlohr Bueso's avatar Davidlohr Bueso Committed by Dave Jiang
Browse files

cxl/pci: Fix potential bogus return value upon successful probing 



If cxl_pci_ras_unmask() returns non-zero, cxl_pci_probe() will end up
returning that value, instead of zero.

Fixes: 248529ed ("cxl: add RAS status unmasking for CXL")
Reviewed-by: default avatarFan Ni <fan.ni@samsung.com>
Signed-off-by: default avatarDavidlohr Bueso <dave@stgolabs.net>
Reviewed-by: default avatarIra Weiny <ira.weiny@intel.com>
Link: https://patch.msgid.link/20241115170032.108445-1-dave@stgolabs.net


Signed-off-by: default avatarDave Jiang <dave.jiang@intel.com>
parent fac04efc

drivers/cxl/pci.c

+1 −2
Original line number Diff line number Diff line
@@ -1032,8 +1032,7 @@ static int cxl_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id) 
	if (rc)

		return rc;



	rc = cxl_pci_ras_unmask(pdev);

	if (rc)

	if (cxl_pci_ras_unmask(pdev))

		dev_dbg(&pdev->dev, "No RAS reporting unmasked\n");



	pci_save_state(pdev);