Commit da550b5a authored by Luca Ceresoli's avatar Luca Ceresoli
Browse files

drm/bridge: put the bridge returned by drm_bridge_get_next_bridge() 



The bridge returned by drm_bridge_get_next_bridge() is refcounted. Put it
when done. We need to ensure it is not put before either next_bridge or
next_bridge_state is in use, thus for simplicity use a cleanup action.

Reviewed-by: default avatarMaxime Ripard <mripard@kernel.org>
Link: https://lore.kernel.org/r/20250801-drm-bridge-alloc-getput-drm_bridge_get_next_bridge-v2-8-888912b0be13@bootlin.com


Signed-off-by: default avatarLuca Ceresoli <luca.ceresoli@bootlin.com>
parent 61aa4f7a

drivers/gpu/drm/drm_bridge.c

+1 −2
Original line number Diff line number Diff line
@@ -1121,7 +1121,6 @@ drm_atomic_bridge_propagate_bus_flags(struct drm_bridge *bridge, 
				      struct drm_atomic_state *state)

{

	struct drm_bridge_state *bridge_state, *next_bridge_state;

	struct drm_bridge *next_bridge;

	u32 output_flags = 0;



	bridge_state = drm_atomic_get_new_bridge_state(state, bridge);
@@ -1130,7 +1129,7 @@ drm_atomic_bridge_propagate_bus_flags(struct drm_bridge *bridge, 
	if (!bridge_state)

		return;



	next_bridge = drm_bridge_get_next_bridge(bridge);

	struct drm_bridge *next_bridge __free(drm_bridge_put) = drm_bridge_get_next_bridge(bridge);



	/*

	 * Let's try to apply the most common case here, that is, propagate