Commit da64a235 authored by Tiezhu Yang's avatar Tiezhu Yang Committed by Huacai Chen
Browse files

LoongArch: Convert unreachable() to BUG() 



When compiling on LoongArch, there exists the following objtool warning
in arch/loongarch/kernel/machine_kexec.o:

  kexec_reboot() falls through to next function crash_shutdown_secondary()

Avoid using unreachable() as it can (and will in the absence of UBSAN)
generate fall-through code. Use BUG() so we get a "break BRK_BUG" trap
(with unreachable annotation).

Cc: stable@vger.kernel.org  # 6.12+
Acked-by: default avatarJosh Poimboeuf <jpoimboe@kernel.org>
Signed-off-by: default avatarTiezhu Yang <yangtiezhu@loongson.cn>
Signed-off-by: default avatarHuacai Chen <chenhuacai@loongson.cn>
parent 7eb17214

arch/loongarch/kernel/machine_kexec.c

+2 −2
Original line number Diff line number Diff line
@@ -126,14 +126,14 @@ void kexec_reboot(void) 
	/* All secondary cpus go to kexec_smp_wait */

	if (smp_processor_id() > 0) {

		relocated_kexec_smp_wait(NULL);

		unreachable();

		BUG();

	}

#endif



	do_kexec = (void *)reboot_code_buffer;

	do_kexec(efi_boot, cmdline_ptr, systable_ptr, start_addr, first_ind_entry);



	unreachable();

	BUG();

}